core/tracker: add missed participation counter #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Apr 10, 2023
| @@ -672,8 +672,8 @@ func newParticipationReporter(peers []p2p.Peer) func(context.Context, core.Duty, | |||
| // Initialise participation metrics to 0 to avoid non-existent metrics issue on startup. | |||
| for _, duty := range core.AllDutyTypes() { | |||
| for _, peer := range peers { | |||
| participationCounter.WithLabelValues(duty.String(), peer.Name).Add(0) | |||
| participationGauge.WithLabelValues(duty.String(), peer.Name).Set(0) | |||
There was a problem hiding this comment.
@dB2510 setting participationGauge to 0 on startup means all peers start a "not participation" which is incorrect since the node didn't have to participate yet, so it hasn't missed or failed participating.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
- Coverage 53.34% 53.33% -0.02%
==========================================
Files 174 174
Lines 22604 22605 +1
==========================================
- Hits 12059 12056 -3
- Misses 9040 9042 +2
- Partials 1505 1507 +2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
xenowits
approved these changes
Apr 10, 2023
corverroos
added
the
merge when ready
LukeHackett12
pushed a commit
that referenced
this pull request
Apr 11, 2023
Adds a `missed participation by peer` counter so that we can calculate `duty participation % per peer` and so we can highlight missed participations instead of only successful participations. category: misc ticket: #2034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
missed participation by peercounter so that we can calculateduty participation % per peerand so we can highlight missed participations instead of only successful participations.category: misc
ticket: #2034